pkuwm commented on a change in pull request #644: Add new interface
IZkStateListener to provide session aware handleNewSession for ZkHelixManager
URL: https://github.com/apache/helix/pull/644#discussion_r355715596
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
##########
@@ -859,20 +886,23 @@ private void reconnect() {
}
private void fireNewSessionEvents() {
+ final String sessionId = Long.toHexString(getSessionId());
for (final IZkStateListener stateListener : _stateListener) {
- _eventThread.send(new ZkEvent("New session event sent to " +
stateListener) {
+ _eventThread.send(new ZkEvent("New session event sent to " +
stateListener, sessionId) {
Review comment:
We don't need to pass it, as session id is already passed to the method.
But I think it would help with debugging when a session id is attached to
the zk event. When there is any exception handling an event, we may have the
session id to help debug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
