zhangmeng916 commented on a change in pull request #647: Add java API to create
cluster with CloudConfig
URL: https://github.com/apache/helix/pull/647#discussion_r356363387
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
##########
@@ -176,6 +179,30 @@ public void close() {
}
}
+ public void addCluster(String clusterName, boolean overwritePrevious,
boolean isCloudEnabled)
+ throws HelixException {
+ if (isCloudEnabled) {
+ String cloudID = System.getProperty(SystemPropertyKeys.CLOUD_ID);
Review comment:
Let's discuss where the system property should be used. If you call the
property key here, it means that the default value for Azure is put in the cfg2
of Helix-rest, which is not quite proper. These cloud features are not part of
Helix Rest configuration. Ideally it should be in participant side, and put in
our client's code cfg2 (e.g. Espresso storage node).
In cluster creation, we just populate whatever we have into Zookeeper. The
remaining is participant's work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
