zhangmeng916 commented on a change in pull request #647: Add java API to create
cluster with CloudConfig
URL: https://github.com/apache/helix/pull/647#discussion_r356867042
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
##########
@@ -176,6 +179,37 @@ public void close() {
}
}
+ public void addCluster(String clusterName, boolean overwritePrevious,
boolean isCloudEnabled,
+ CloudConfig cloudConfig) throws HelixException {
+ if (isCloudEnabled) {
+ if (cloudConfig != null) {
+ String cloudID = cloudConfig.getCloudID();
+ String cloudProvider = cloudConfig.getCloudProvider();
+ List<String> cloudInfoSource = cloudConfig.getCloudInfoSources();
+ String cloudProcessorName = cloudConfig.getCloudInfoProcessorName();
+
+ // Validate the cloudConfig in the builder
+ // If it is invalid, do not even create a cluster
+ CloudConfig.Builder builder = new CloudConfig.Builder(clusterName);
+ builder.setCloudEnabled(true);
Review comment:
It's better to use chained builder so that you only need to have one line of
code. I noticed some existing ones don't use chain. But for concise code, let's
use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
