zhangmeng916 commented on a change in pull request #647: Add java API to create
cluster with CloudConfig
URL: https://github.com/apache/helix/pull/647#discussion_r356361876
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
##########
@@ -176,6 +179,30 @@ public void close() {
}
}
+ public void addCluster(String clusterName, boolean overwritePrevious,
boolean isCloudEnabled)
Review comment:
Thinking this thoroughly, I believe we need more parameters than
"isCloudEnabled". cloudID is dynamically generated every time, and we do not
have default value for it. With that said, it makes more sense for users to be
able to input "cloudProvider" and "cloudId" when the cloud is "enabled". We
should assume that we always have "Azure" as default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
