jiajunwang commented on a change in pull request #647: Add java API to create
cluster with CloudConfig
URL: https://github.com/apache/helix/pull/647#discussion_r359063736
##########
File path: helix-core/src/main/java/org/apache/helix/model/CloudConfig.java
##########
@@ -207,6 +207,16 @@ public Builder(CloudConfig cloudConfig) {
_cloudInfoProcessorName = cloudConfig.getCloudInfoProcessorName();
}
+ public Builder(String cluster, boolean enabled, CloudProvider
cloudProvider, String cloudID,
+ List<String> cloudInfoSource, String cloudProcessorName) {
+ _clusterName = cluster;
Review comment:
nit, let's try to keep the parameter names the same with the fields' names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
