jiajunwang commented on a change in pull request #647: Add java API to create
cluster with CloudConfig
URL: https://github.com/apache/helix/pull/647#discussion_r359063147
##########
File path: helix-core/src/main/java/org/apache/helix/HelixAdmin.java
##########
@@ -380,6 +380,13 @@ void addStateModelDef(String clusterName, String
stateModelDef, StateModelDefini
*/
void dropResource(String clusterName, String resourceName);
+ /**
+ *
+ * @param clusterName
+ * @param cloudConfig
+ */
+ void addCloudConfig(String clusterName, CloudConfig cloudConfig);
Review comment:
So we never remove the config?
For a complete operation set, I'd prefer we have a delete cluster config
interface. Or call it setCloudConfig so it can be removed by passing null
parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
