jiajunwang commented on a change in pull request #647: Add java API to create
cluster with CloudConfig
URL: https://github.com/apache/helix/pull/647#discussion_r359066289
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
##########
@@ -176,6 +179,31 @@ public void close() {
}
}
+ public void addCluster(String clusterName, boolean overwritePrevious,
CloudConfig cloudConfig)
+ throws HelixException {
+ if (cloudConfig != null) {
+ if (cloudConfig.isCloudEnabled()) {
+ String cloudID = cloudConfig.getCloudID();
+ String cloudProvider = cloudConfig.getCloudProvider();
+ List<String> cloudInfoSources = cloudConfig.getCloudInfoSources();
+ String cloudProcessorName = cloudConfig.getCloudInfoProcessorName();
+
+ // Validate the cloudConfig in the builder
+ // If it is invalid, do not even create a cluster
+ CloudConfig.Builder builder = new CloudConfig.Builder(clusterName,
true,
+ CloudProvider.valueOf(cloudProvider), cloudID, cloudInfoSources,
cloudProcessorName);
+
+ CloudConfig validatedCloudConfig = builder.build();
+ addCluster(clusterName, overwritePrevious);
Review comment:
So as I mentioned above, if we have the validation method, we don't need to
have 2 lines of addCluster, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
