jiajunwang commented on a change in pull request #642: Fix handleNewSession creating ephemeral node with expired session URL: https://github.com/apache/helix/pull/642#discussion_r361014556
########## File path: helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java ########## @@ -77,14 +76,17 @@ final LiveInstanceInfoProvider _liveInstanceInfoProvider; final List<PreConnectCallback> _preConnectCallbacks; + private final String _sessionId; Review comment: This is probably OK, but one minor concern is none backward compatible that you change this field to private. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
