jiajunwang commented on a change in pull request #642: Fix handleNewSession
creating ephemeral node with expired session
URL: https://github.com/apache/helix/pull/642#discussion_r361014855
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -97,10 +99,25 @@ public ParticipantManager(HelixManager manager,
HelixZkClient zkclient, int sess
}
/**
- * Handle new session for a participang.
- * @throws Exception
+ * Handles a new session for a participant. The new session's id is passed
in when participant
+ * manager is created, as it is required in
+ * {@link
org.apache.helix.manager.zk.zookeeper.ZkClient#createEphemeral(String, Object,
String)}
+ * to prevent ephemeral node creation from session race condition: ephemeral
node is created by an
+ * expired or unexpected session.
+ *
+ * @throws Exception if any exception occurs
*/
public void handleNewSession() throws Exception {
Review comment:
I might have been confused, but shouldn't we have a new handleNewSession
method that takes a session Id as parameter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
