jiajunwang commented on a change in pull request #642: Fix handleNewSession
creating ephemeral node with expired session
URL: https://github.com/apache/helix/pull/642#discussion_r364003612
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -697,10 +699,19 @@ void createClient() throws Exception {
int retryCount = 0;
while (retryCount < 3) {
try {
- // TODO: synchronize this block and wait for the new non-zero session
ID updated.
- _zkclient.waitUntilConnected(_connectionInitTimeout,
TimeUnit.MILLISECONDS);
+ // TODO: get session id from waitUntilConnected to avoid race condition
Review comment:
This is OK. Just a reminder that we need to finish this TODO until the bug
is finished.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
