jiajunwang commented on a change in pull request #653: add Helix properties
factory and class
URL: https://github.com/apache/helix/pull/653#discussion_r364027213
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -202,6 +205,11 @@ public ZKHelixManager(String clusterName, String
instanceName, InstanceType inst
public ZKHelixManager(String clusterName, String instanceName, InstanceType
instanceType,
String zkAddress, HelixManagerStateListener stateListener) {
+ this(clusterName, instanceName, instanceType, zkAddress,stateListener,
null);
+ }
+
+ public ZKHelixManager(String clusterName, String instanceName, InstanceType
instanceType,
+ String zkAddress, HelixManagerStateListener stateListener,
HelixParticipantProperty helixParticipantProperty) {
Review comment:
And we might want to deprecate the older constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
