jiajunwang commented on a change in pull request #653: add Helix properties
factory and class
URL: https://github.com/apache/helix/pull/653#discussion_r366733903
##########
File path:
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkClusterManager.java
##########
@@ -63,18 +63,11 @@ public void testController() throws Exception {
_gZkClient.deleteRecursively("/" + clusterName);
}
+ TestHelper.setupEmptyCluster(_gZkClient, clusterName);
+
ZKHelixManager controller =
new ZKHelixManager(clusterName, null, InstanceType.CONTROLLER,
ZK_ADDR);
- try {
- controller.connect();
- Assert.fail("Should throw HelixException if initial cluster structure is
not setup");
Review comment:
Why this test logic is removed? We don't throw exceptions on empty cluster
structure anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
