jiajunwang commented on a change in pull request #662: Mitigate controller
leadership switch latency - improve leader -> standby
URL: https://github.com/apache/helix/pull/662#discussion_r368314542
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -583,8 +580,7 @@ private void subscribeForChanges(NotificationContext.Type
callbackType, String p
* exists
*/
public void init() {
- logger.info("initializing CallbackHandler: " + this.toString() + "
content: " + getContent());
-
+ logger.info("Initializing CallbackHandler, content: {}", getContent());
Review comment:
Why reduce the information here? The logger is constructed with
CallbackHandler class, it is not clear for us which child class it might be if
you remove the this.toString().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
