i3wangyi commented on a change in pull request #662: Mitigate controller
leadership switch latency - improve leader -> standby
URL: https://github.com/apache/helix/pull/662#discussion_r373747823
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -780,13 +780,10 @@ public void disconnect() {
// TODO reset user defined handlers only
// TODO Fix the issue that when connection disconnected, reset handlers
will be blocked. -- JJ
- // This is because reset logic contains ZK operations.
- resetHandlers(true);
Review comment:
Yeah. That's the design of using `unsubscribeAll`. Because the current
callback handler's FINALIZE method is pretty expensive (involving read all
children node under currentstates then remove them one by one).
I could perform tests that prove without the FINALIZE event, HelixManager
could clean up all information when `disconnect()`. And the single callback
handler could still use the FINALIZE event to un-register itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
