jiajunwang commented on a change in pull request #662: Mitigate controller
leadership switch latency - improve leader -> standby
URL: https://github.com/apache/helix/pull/662#discussion_r368314837
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -501,23 +501,20 @@ private void
subscribeForChangesAsyn(NotificationContext.Type callbackType, Stri
private void subscribeForChanges(NotificationContext.Type callbackType,
String path,
boolean watchChild) {
- logger.info("Subscribing changes listener to path: " + path + ", type: " +
callbackType
- + ", listener: " + _listener);
+ logger
+ .info("Subscribing changes listener on path: {}, callbackType: {},
listener: {}, isWatchChild: {}",
+ path, callbackType, _listener, watchChild);
long start = System.currentTimeMillis();
if (_eventTypes.contains(EventType.NodeDataChanged)
|| _eventTypes.contains(EventType.NodeCreated)
|| _eventTypes.contains(EventType.NodeDeleted)) {
- logger.info("Subscribing data change listener to path: " + path);
Review comment:
Why removing these logs? While debugging, how do we know if this listener is
configured with what kind of _eventTypes list? Since there are still some
concerns or bug reports regarding callbacks, we'd better keep the detail logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
