jiajunwang commented on a change in pull request #690: Reset the WAGED
rebalancer once the controller newly acquires leadership.
URL: https://github.com/apache/helix/pull/690#discussion_r370778177
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
##########
@@ -249,23 +220,33 @@ private boolean validateOfflineInstancesLimit(final
ResourceControllerDataProvid
return true;
}
+ private void updateWagedRebalancer(WagedRebalancer wagedRebalancer,
ClusterConfig clusterConfig) {
Review comment:
That's a good point. For now, an explicit check would be optional. If the
rebalancer has been closed, the computing will fail. One concern might be
metric. It will be unregistered after the close.
Let me add a TODO to the close() method. I would prefer to keep this PR
simple for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
