jiajunwang commented on a change in pull request #690: Reset the WAGED
rebalancer once the controller newly acquires leadership.
URL: https://github.com/apache/helix/pull/690#discussion_r370786375
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
##########
@@ -249,23 +220,33 @@ private boolean validateOfflineInstancesLimit(final
ResourceControllerDataProvid
return true;
}
+ private void updateWagedRebalancer(WagedRebalancer wagedRebalancer,
ClusterConfig clusterConfig) {
Review comment:
One more comment, for now, the close is only called in 2 conditions:
1. the instance is GCed. So there should be no one calling any methods.
2. The controller is shutdown. There won't be a pipeline running after. So
there should be no one calling any methods.
That's why I don't think we need to do this check immediately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
