jiajunwang commented on a change in pull request #690: Reset the WAGED rebalancer once the controller newly acquires leadership. URL: https://github.com/apache/helix/pull/690#discussion_r370784633
########## File path: helix-core/src/main/java/org/apache/helix/controller/stages/AttributeName.java ########## @@ -38,5 +38,6 @@ AsyncFIFOWorkerPool, PipelineType, LastRebalanceFinishTimeStamp, - ControllerDataProvider + ControllerDataProvider, + STATEFUL_REBALANCER Review comment: Thanks for the feedback. As for the convention, it is not really clear to me. So I did some research. There are different opinions. The one that seems to be more reasonable to me is that enum items should be treated as constants, so they should follow constants name convention. Given this, uppercase letters make more sense here. I intend to enforce this as our enum convention unless a different rule has been documented somewhere else that I don't know : ) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
