jiajunwang commented on a change in pull request #690: Reset the WAGED
rebalancer once the controller newly acquires leadership.
URL: https://github.com/apache/helix/pull/690#discussion_r371460331
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
##########
@@ -249,23 +220,33 @@ private boolean validateOfflineInstancesLimit(final
ResourceControllerDataProvid
return true;
}
+ private void updateWagedRebalancer(WagedRebalancer wagedRebalancer,
ClusterConfig clusterConfig) {
Review comment:
I'd prefer adding a TODO to add this check properly. Since that is not one
or two lines of change, let's not squeeze it into this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
