narendly commented on a change in pull request #763: SharedZKClient
URL: https://github.com/apache/helix/pull/763#discussion_r379661215
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -170,13 +172,21 @@ public void recordPathStat(Stat stat, OptionalLong
notificationTime) {
}
}
}
-
protected ZkClient(IZkConnection zkConnection, int connectionTimeout, long
operationRetryTimeout,
PathBasedZkSerializer zkSerializer, String monitorType, String
monitorKey,
String monitorInstanceName, boolean monitorRootPathOnly) {
+ this(null, zkConnection, connectionTimeout, operationRetryTimeout,
+ zkSerializer, monitorType, monitorKey,
+ monitorInstanceName, monitorRootPathOnly);
+ }
+
+ protected ZkClient(String realmKey, IZkConnection zkConnection, int
connectionTimeout, long operationRetryTimeout,
Review comment:
This is the native ZkClient. I don't think this is a good idea to touch the
native ZkClient for the reasons stated above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
