narendly commented on a change in pull request #763: SharedZKClient
URL: https://github.com/apache/helix/pull/763#discussion_r379660897
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/ZkClient.java
##########
@@ -90,7 +90,15 @@ public ZkClient(IZkConnection zkConnection, int
connectionTimeout, long operatio
PathBasedZkSerializer zkSerializer,
String monitorType, String monitorKey, String monitorInstanceName,
boolean monitorRootPathOnly) {
- super(zkConnection, connectionTimeout, operationRetryTimeout,
zkSerializer, monitorType,
+ super(null, zkConnection, connectionTimeout, operationRetryTimeout,
zkSerializer, monitorType,
+ monitorKey, monitorInstanceName, monitorRootPathOnly);
+ }
+
+ public ZkClient(String realmKey, IZkConnection zkConnection, int
connectionTimeout, long operationRetryTimeout,
Review comment:
I don't think making the raw ZkClient realm-aware is appropriate because
it's supposed to be a "raw" ZkClient that preserves the behavior of what we had
in I0Itec's ZkClient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
