dasahcc commented on a change in pull request #763: SharedZKClient
URL: https://github.com/apache/helix/pull/763#discussion_r379661309
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java
##########
@@ -72,6 +72,25 @@ public SharedZkClient(ZkConnectionManager
connectionManager, ZkClientConfig clie
_onCloseCallback = callback;
}
+ /**
+ * Construct a shared RealmAwareZkClient that uses a shared ZkConnection.
+ *
+ * @param connectionManager The manager of the shared ZkConnection.
+ * @param clientConfig ZkClientConfig details to create the shared
RealmAwareZkClient.
+ * @param callback Clean up logic when the shared
RealmAwareZkClient is closed.
+ */
+ public SharedZkClient(String realmKey, ZkConnectionManager
connectionManager, RealmAwareZkClientConfig clientConfig,
Review comment:
Can we have consistent pattern of constructor for DedicatedZkClient and
SharedZKClient? This constructor is different from @narendly 's constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
