narendly commented on issue #788: WIP: Implement request forwarding for ZkRoutingDataWriter URL: https://github.com/apache/helix/pull/788#issuecomment-589986934 Note on this PR: 1. As discussed offline, let's make ZkMetadataStoreDirectory a static singleton that is shared throughout the server's process. The benefit of this is that each REST server will truly act as one entity, which is necessary because we use distributed leader election to designate a single writer. 2. With that said, we would need to add both unit and integration tests. With an introduction of a singleton class, testing might not be so straightforward, but as discussed in person, it might be possible by creating mock classes. Good job and let's continue adding tests and reviewing this PR :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
