narendly commented on a change in pull request #788: Implement request
forwarding for ZkRoutingDataWriter
URL: https://github.com/apache/helix/pull/788#discussion_r384310960
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/accessor/ZkRoutingDataWriter.java
##########
@@ -40,8 +52,11 @@
private final String _namespace;
private final HelixZkClient _zkClient;
private final ZkDistributedLeaderElection _leaderElection;
+ private final CloseableHttpClient _forwardHttpClient;
+ private final String _myHostName;
public ZkRoutingDataWriter(String namespace, String zkAddress) {
+ System.out.println("writer created namespace=" + namespace + " zkAddress="
+ zkAddress);
Review comment:
Remove print statements? We want to avoid this kind of stuff in production
code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
