narendly commented on a change in pull request #796: WIP: Add
SharedZkClient/InnerSharedZkClient implementation
URL: https://github.com/apache/helix/pull/796#discussion_r382935534
##########
File path:
zookeeper-api/src/test/java/org/apache/helix/zookeeper/impl/client/TestSharedZkClient.java
##########
@@ -0,0 +1,16 @@
+package org.apache.helix.zookeeper.impl.client;
+
+import org.apache.helix.zookeeper.impl.factory.DedicatedZkClientFactory;
+import org.apache.helix.zookeeper.impl.factory.SharedZkClientFactory;
+import org.testng.annotations.BeforeClass;
+
+
+public class TestSharedZkClient extends RealmAwareZkClientTestBase {
Review comment:
@kaisun2000
As we discussed, there are a few more test cases we need to add to this test
class.
Could you please add more comprehensive test cases that cover ephemeral node
operations for SharedZkClient?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
