narendly commented on a change in pull request #796: WIP: Add
SharedZkClient/InnerSharedZkClient implementation
URL: https://github.com/apache/helix/pull/796#discussion_r382934440
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/api/factory/RealmAwareZkClientFactory.java
##########
@@ -45,11 +45,17 @@ RealmAwareZkClient
buildZkClient(RealmAwareZkClient.RealmAwareZkConnectionConfig
* @param metadataStoreRoutingData
* @return RealmAwareZkClient
*/
+
// TODO: remove MetadataStoreRoutingData
default RealmAwareZkClient buildZkClient(
RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig,
MetadataStoreRoutingData metadataStoreRoutingData) {
return buildZkClient(connectionConfig, new
RealmAwareZkClient.RealmAwareZkClientConfig(),
metadataStoreRoutingData);
+ /*
+ default RealmAwareZkClient buildZkClient(
+ RealmAwareZkClient.RealmAwareZkConnectionConfig connectionConfig) {
+ return buildZkClient(connectionConfig, new
RealmAwareZkClient.RealmAwareZkClientConfig());
+ */
Review comment:
Why is this necessary? Since we already have a TODO, we don't need to leave
this here as a block comment.
In general, our coding standards are such that we avoid code that's blocked
out like this. Please consider removing this as you revise this PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
