narendly commented on a change in pull request #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#discussion_r382934559
########## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java ########## @@ -20,13 +20,27 @@ */ import java.util.List; +import java.util.Map; +import java.util.concurrent.TimeUnit; +import org.apache.helix.msdcommon.datamodel.MetadataStoreRoutingData; import org.apache.helix.zookeeper.api.client.HelixZkClient; -import org.apache.helix.zookeeper.impl.factory.ZkConnectionManager; -import org.apache.helix.zookeeper.zkclient.IZkConnection; -import org.apache.helix.zookeeper.zkclient.ZkConnection; +import org.apache.helix.zookeeper.api.client.RealmAwareZkClient; +import org.apache.helix.zookeeper.impl.factory.SharedZkClientFactory; +import org.apache.helix.zookeeper.zkclient.DataUpdater; +import org.apache.helix.zookeeper.zkclient.IZkChildListener; +import org.apache.helix.zookeeper.zkclient.IZkDataListener; +import org.apache.helix.zookeeper.zkclient.callback.ZkAsyncCallbacks; +import org.apache.helix.zookeeper.zkclient.deprecated.IZkStateListener; Review comment: If this is going to build without this import, then we should remove it. If this doesn't build, let us leave this here for the time being, and let's use https://github.com/apache/helix/issues/783 to track this work. How does this sound @pkuwm ? This will be much easier because we could establish a clear action plan as a whole as to how we should remove these deprecated classes altogether throughout the codebase. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
