narendly commented on a change in pull request #819: Make RealmAwareZkClient implementations use HttpRoutingDataReader for routing data URL: https://github.com/apache/helix/pull/819#discussion_r387492149
########## File path: zookeeper-api/src/test/java/org/apache/helix/zookeeper/constant/TestConstants.java ########## @@ -0,0 +1,45 @@ +package org.apache.helix.zookeeper.constant; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.util.Collection; +import java.util.Map; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.ImmutableMap; + + +/** + * Constants to be used for testing. + */ +public class TestConstants { + // ZK hostname prefix and port to be used throughout the zookeeper-api module + public static final String ZK_PREFIX = "localhost:"; + public static final int ZK_START_PORT = 2127; + + // Based on the ZK hostname constants, construct a set of fake routing data mappings + public static Map<String, Collection<String>> FAKE_ROUTING_DATA = ImmutableMap Review comment: Added final! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
