pkuwm commented on a change in pull request #819: Make RealmAwareZkClient
implementations use HttpRoutingDataReader for routing data
URL: https://github.com/apache/helix/pull/819#discussion_r387441969
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/DedicatedZkClient.java
##########
@@ -56,32 +59,42 @@
private final ZkClient _rawZkClient;
private final MetadataStoreRoutingData _metadataStoreRoutingData;
private final String _zkRealmShardingKey;
- private final String _zkRealmAddress;
- // TODO: Remove MetadataStoreRoutingData from constructor
+ /**
+ * DedicatedZkClient connects to a single ZK realm and supports full
ZkClient functionalities
+ * such as CRUD, change callback, and ephemeral operations for a single
ZkRealmShardingKey.
+ * @param connectionConfig
+ * @param clientConfig
+ * @throws IOException
+ * @throws InvalidRoutingDataException
+ */
public DedicatedZkClient(RealmAwareZkClient.RealmAwareZkConnectionConfig
connectionConfig,
- RealmAwareZkClient.RealmAwareZkClientConfig clientConfig,
- MetadataStoreRoutingData metadataStoreRoutingData) {
-
+ RealmAwareZkClient.RealmAwareZkClientConfig clientConfig)
+ throws IOException, InvalidRoutingDataException {
if (connectionConfig == null) {
throw new IllegalArgumentException("RealmAwareZkConnectionConfig cannot
be null!");
}
- _zkRealmShardingKey = connectionConfig.getZkRealmShardingKey();
+ if (clientConfig == null) {
+ throw new IllegalArgumentException("RealmAwareZkConnectionConfig cannot
be null!");
Review comment:
Typo in exception message. Should be RealmAwareZkClientConfig
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
