narendly commented on a change in pull request #819: Make RealmAwareZkClient
implementations use HttpRoutingDataReader for routing data
URL: https://github.com/apache/helix/pull/819#discussion_r387219455
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/FederatedZkClient.java
##########
@@ -80,19 +83,17 @@
private PathBasedZkSerializer _pathBasedZkSerializer;
// TODO: support capacity of ZkClient number in one FederatedZkClient and do
garbage collection.
- public FederatedZkClient(RealmAwareZkClient.RealmAwareZkClientConfig
clientConfig,
- MetadataStoreRoutingData metadataStoreRoutingData) {
- if (metadataStoreRoutingData == null) {
- throw new IllegalArgumentException("MetadataStoreRoutingData cannot be
null!");
- }
+ public FederatedZkClient(RealmAwareZkClient.RealmAwareZkClientConfig
clientConfig)
+ throws IOException, InvalidRoutingDataException {
Review comment:
- FederatedZkClient is still a low-level construct
- This means that the users of this component will mostly be Helix Java
APIs, and probably a few users who wish to use directly.
- In that case, I think we still need to float these exceptions up and
handle each case at the Helix Java API level. That way, we make it 1)
user-friendly and 2) we still achieve the low-level granularity with
FederatedZkClient that users of this class would want instead of hiding failure
types behind an IllegalStateException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
