zhangmeng916 commented on a change in pull request #851: Add customized view computation and modify Helix generic controller to include new stage URL: https://github.com/apache/helix/pull/851#discussion_r389074906
########## File path: helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java ########## @@ -96,13 +99,15 @@ // Special caches private CurrentStateCache _currentStateCache; + private CustomizedStateCache _customizedStateCache; private InstanceMessagesCache _instanceMessagesCache; // Other miscellaneous caches private Map<String, Long> _instanceOfflineTimeMap; private Map<String, Map<String, String>> _idealStateRuleMap; private Map<String, Map<String, Set<String>>> _disabledInstanceForPartitionMap = new HashMap<>(); private Set<String> _disabledInstanceSet = new HashSet<>(); + private Set<String> _aggregationEnabledTypes = new HashSet<>(); Review comment: I've removed it, it used to be used by customized state cache, but now we've changed that cache and access the customized state config directly in the cache. So we do not need this variable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
