jiajunwang commented on a change in pull request #867: Make
ZkHelixClusterVerifier and its child classes realm-aware
URL: https://github.com/apache/helix/pull/867#discussion_r388725401
##########
File path:
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -84,7 +83,7 @@ public BestPossibleExternalViewVerifier(String zkAddr,
String clusterName, Set<S
_dataProvider = new ResourceControllerDataProvider();
}
- public BestPossibleExternalViewVerifier(HelixZkClient zkClient, String
clusterName,
+ public BestPossibleExternalViewVerifier(RealmAwareZkClient zkClient, String
clusterName,
Review comment:
Since we have the builder, shall we deprecated all the other constructors?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
