narendly commented on a change in pull request #867: Make
ZkHelixClusterVerifier and its child classes realm-aware
URL: https://github.com/apache/helix/pull/867#discussion_r389842491
##########
File path:
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -94,29 +93,43 @@ public BestPossibleExternalViewVerifier(HelixZkClient
zkClient, String clusterNa
_dataProvider = new ResourceControllerDataProvider();
}
- public static class Builder {
- private String _clusterName;
+ private
BestPossibleExternalViewVerifier(BestPossibleExternalViewVerifier.Builder
builder) {
+ super(builder);
+ _errStates = builder._errStates;
+ _resources = builder._resources;
+ _expectLiveInstances = builder._expectLiveInstances;
Review comment:
Good point. I'll address this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
