pkuwm commented on a change in pull request #867: Make ZkHelixClusterVerifier
and its child classes realm-aware
URL: https://github.com/apache/helix/pull/867#discussion_r391241927
##########
File path:
helix-core/src/main/java/org/apache/helix/tools/ClusterVerifiers/BestPossibleExternalViewVerifier.java
##########
@@ -94,29 +95,47 @@ public BestPossibleExternalViewVerifier(HelixZkClient
zkClient, String clusterNa
_dataProvider = new ResourceControllerDataProvider();
}
- public static class Builder {
- private String _clusterName;
+ private BestPossibleExternalViewVerifier(Builder builder) {
+ super(builder);
+ // Deep copy data from Builder
Review comment:
It seems the original constructors don't do deep copy. Is there a reason we
do deep copy here? Maybe to prevent it from any concurrent modification
exception as seen in prod or tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
