zhangmeng916 commented on a change in pull request #876: Add construction of
domain in Helix participant logic
URL: https://github.com/apache/helix/pull/876#discussion_r389217116
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -200,6 +201,22 @@ private void joinCluster() {
}
}
+ private String ConstructDomainField(String faultDomain) {
+ Boolean topologyEnabled =
_configAccessor.getClusterConfig(_clusterName).isTopologyAwareEnabled();
Review comment:
Discussed offline. We'll move the logic to cloud instance information
processor and not to depend on cluster config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
