dasahcc commented on a change in pull request #876: Add construction of domain
in Helix participant logic
URL: https://github.com/apache/helix/pull/876#discussion_r389902393
##########
File path:
helix-core/src/main/java/org/apache/helix/cloud/azure/AzureCloudInstanceInformationProcessor.java
##########
@@ -142,8 +142,16 @@ public AzureCloudInstanceInformation
parseCloudInstanceInformation(List<String>
String vmName = computeNode.path(INSTANCE_NAME).getTextValue();
String platformFaultDomain = computeNode.path(DOMAIN).getTextValue();
String vmssName = computeNode.path(INSTANCE_SET_NAME).getValueAsText();
+ String azureTopology = AzureConstants.AZURE_TOPOLOGY;
+ String[] parts = azureTopology.trim().split("/");
+ if (parts.length != 2) {
+ throw new HelixException("Invalid Azure topology definition: " +
azureTopology);
+ }
Review comment:
This is not necessary, right? Unless we offer flexibility for user to
customize it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
