dasahcc commented on a change in pull request #876: Add construction of domain
in Helix participant logic
URL: https://github.com/apache/helix/pull/876#discussion_r389903510
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
##########
@@ -178,7 +178,7 @@ private void joinCluster() {
LOG.info(_instanceName + " is auto-registering cluster: " +
_clusterName);
CloudInstanceInformation cloudInstanceInformation =
getCloudInstanceInformation();
String domain = cloudInstanceInformation
-
.get(CloudInstanceInformation.CloudInstanceField.FAULT_DOMAIN.name());
+
.get(CloudInstanceInformation.CloudInstanceField.FAULT_DOMAIN.name()) +
_instanceName;
Review comment:
This is domain string right? Then it should looked like "FD=xxx,
InstanceName=xxxx". But the code is adding them together?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
