jiajunwang commented on a change in pull request #834: Complete the Routing
Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r392537348
##########
File path:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
##########
@@ -700,12 +1003,13 @@ public void queueEvent(NotificationContext context,
ClusterEventType eventType,
event.addAttribute(AttributeName.helixmanager.name(),
context.getManager());
event.addAttribute(AttributeName.changeContext.name(), context);
queueEvent(event);
-
- _monitor.increaseCallbackCounters(_eventQueue.size());
+ for (PropertyType propertyType : _monitorMap.keySet()) {
+
_monitorMap.get(propertyType).increaseCallbackCounters(_eventQueue.size());
Review comment:
One question, if we have multiple state types for the customized state view,
do we have multiple event count for this monitor? Wil that be bad?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
