jiajunwang commented on a change in pull request #834: Complete the Routing Table Provider for CustomizedView URL: https://github.com/apache/helix/pull/834#discussion_r392533274
########## File path: helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java ########## @@ -83,17 +87,27 @@ private ExecutorService _reportExecutor; private Future _reportingTask = null; + protected static final String DEFAULT_PROPERTY = "HELIX_DEFAULT_PROPERTY"; Review comment: DEFAULT_PROPERTY_TYPE and DEFAULT_STATE_TYPE are cleaner, IMHO. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
