jiajunwang commented on a change in pull request #834: Complete the Routing
Table Provider for CustomizedView
URL: https://github.com/apache/helix/pull/834#discussion_r392522484
##########
File path:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTable.java
##########
@@ -351,6 +373,23 @@ ResourceGroupInfo getResourceGroup(String
resourceGroupName) {
return Collections.unmodifiableCollection(_externalViews);
}
+ /**
+ * Returns PropertyTYpe
+ * @return the PropertyTYpe of this RoutingTable
+ */
+ protected PropertyType getPropertyType() {
+ return _propertyType;
+ }
+
+ /**
+ * Returns CustomizedStateType
+ * @return the CustomizedStateType of this RoutingTable (Used for
CustomizedView)
+ */
+ protected String getCustomizedStateType() {
Review comment:
Make it more generic, getStateType(). Every state can refer to this type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]