jiajunwang commented on a change in pull request #851: Modify Helix generic
controller to include new stage for customized view aggregation
URL: https://github.com/apache/helix/pull/851#discussion_r396824725
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -569,12 +570,19 @@ public void
addCurrentStateChangeListener(org.apache.helix.CurrentStateChangeLis
});
}
+ @Override
+ public void
addCustomizedStateRootChangeListener(CustomizedStateRootChangeListener listener,
+ String instanceName) throws Exception {
+ addListener(listener, new
Builder(_clusterName).customizedStatesRoot(instanceName),
+ ChangeType.CUSTOMIZED_STATE_ROOT, new
EventType[]{EventType.NodeChildrenChanged});
+ }
+
@Override
public void addCustomizedStateChangeListener(CustomizedStateChangeListener
listener,
- String instanceName, String customizedStateName) throws Exception {
- addListener(listener, new
Builder(_clusterName).customizedStates(instanceName, customizedStateName),
- ChangeType.CUSTOMIZED_STATE, new EventType[] {
EventType.NodeChildrenChanged
- });
+ String instanceName, String customizedStateType) throws Exception {
Review comment:
That would be one additional layer than the current callbackhandler
infrastructure can support.
I would like to have a try to improve it after this PR is in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
