zhangmeng916 commented on a change in pull request #851: Modify Helix generic
controller to include new stage for customized view aggregation
URL: https://github.com/apache/helix/pull/851#discussion_r396867483
##########
File path: helix-core/src/main/java/org/apache/helix/PropertyKey.java
##########
@@ -474,6 +474,15 @@ public PropertyKey currentState(String instanceName,
String sessionId, String re
}
}
+ /**
+ * Get a property key associated with the root of {@link CustomizedState}
of an instance
+ * @param instanceName
+ * @return {@link PropertyKey}
+ */
+ public PropertyKey customizedStatesRoot(String instanceName) {
Review comment:
This might cause more confusion as there're many places that have
customizedStates as variable name. I fear it actually makes the later
modification (combine two layers) more difficult. Have a "root" name here can
help us know exactly where need to be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
