kaisun2000 commented on a change in pull request #924: WIP: fix
ZkHelixPropertyStore loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#discussion_r401178173
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java
##########
@@ -72,6 +72,11 @@
private HelixZkClient _zkClient = null;
+ // test only
+ public HelixZkClient getZkClient() {
Review comment:
Protect is not going to work, as the test case live in another package.
Java has not way to access otherwise private members in the class. In this
case, we have to expire the session inside this class. This is a common pattern
I did not see addressed in our code base. Unless you guys can identify another
pattern, I guess we have to leave it this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
