kaisun2000 commented on a change in pull request #924: WIP: fix
ZkHelixPropertyStore loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#discussion_r401178796
##########
File path:
helix-core/src/main/java/org/apache/helix/store/zk/ZkHelixPropertyStore.java
##########
@@ -47,4 +48,9 @@ public ZkHelixPropertyStore(String zkAddress, ZkSerializer
serializer, String ch
ZkBaseDataAccessor.ZkClientType zkClientType) {
super(zkAddress, serializer, chrootPath, null, null, MONITOR_TYPE,
chrootPath, zkClientType);
}
+
+ // test only
+ protected HelixZkClient getTestZkClient() {
+ return getZkClient();
+ }
Review comment:
Java has not way to access otherwise private members in the class. In this
case, we have to expire the session inside this class. This is a common problem
I did not see addressed in our code base. Unless you guys can identify another
pattern, I guess we have to leave it this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
