lei-xia commented on a change in pull request #924: WIP: fix
ZkHelixPropertyStore loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#discussion_r401186639
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/client/SharedZkClient.java
##########
@@ -112,4 +112,9 @@ public String create(final String path, Object datat,
final List<ACL> acl,
protected boolean isManagingZkConnection() {
return false;
}
+
+ // test only
+ public HelixZkClient getConnectionManager() {
+ return _connectionManager;
+ }
Review comment:
Agreed here, we should never add a public method to a public class just for
testing. If you really need to expose ZkClient, either change it to protected,
and inherit this class in your test, such that:
class SharedZkClient {
protected _zkClient;
}
class testSharedZkClient extends SharedZkClient {
Protected getZkClient() {
return _zkClient;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
