jiajunwang commented on a change in pull request #924: WIP: fix
ZkHelixPropertyStore loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#discussion_r402031952
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/zkclient/ZkClient.java
##########
@@ -1073,10 +1073,24 @@ protected void processStateChanged(WatchedEvent event)
{
fireStateChangedEvent(event.getState());
+ // This following is the case for ZkClient no managing connection
if (!isManagingZkConnection()) {
+ /*
+ * For SharedZkClient, we will not invoke fireNewSessionEvents but will
invoke fireAllEvents
+ * This keeps the same behavior as original SharedZkClient.
+ * Invoking fireAllEvents is important to make sure HelixPropertyStore
working correctly.
+ */
+ if ((event.getState() == KeeperState.SyncConnected) &&
(!_isNewSessionEventFired) && (!"0"
+ .equals(getHexSessionId()))) {
+ fireAllEvents();
+ _isNewSessionEventFired = true;
+ } else if (event.getState() == KeeperState.Expired) {
+ _isNewSessionEventFired = false;
+ }
return;
}
+ // The following is the case for ZkClient managing the connection
Review comment:
I guess it can be simplified to:
// else, if managing the connection
Anyway, if we do what Huizhi suggested, it should be clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
