kaisun2000 commented on a change in pull request #924: WIP: fix 
ZkHelixPropertyStore loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#discussion_r402514561
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/ZkTestHelper.java
 ##########
 @@ -146,6 +146,70 @@ public void process(WatchedEvent event) {
     LOG.info("After expiry. sessionId: " + 
Long.toHexString(curZookeeper.getSessionId()));
   }
 
+  public static void expireSharedZkClientSession(HelixZkClient client) throws 
Exception {
 
 Review comment:
   It is different for a reason. Shared ZkClient does not have 
handleNewSession. Will combine see the above discussion with JJ.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to