narendly commented on a change in pull request #968:
URL: https://github.com/apache/helix/pull/968#discussion_r414164085
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
##########
@@ -112,13 +112,13 @@ public static boolean isClusterSetup(String clusterName,
RealmAwareZkClient zkCl
for (int i = 0; i < ret.length; i++) {
if (!ret[i]) {
isValid = false;
- errorMsg.append("Invalid cluster setup, missing znode path:
").append(requiredPaths.get(i))
- .append("\n");
+ errorMsg.append("Invalid cluster setup for cluster:
").append(clusterName)
+ .append(", missing znode path:
").append(requiredPaths.get(i)).append("\n");
}
}
if (!isValid) {
- logger.debug(errorMsg.toString());
+ logger.warn(errorMsg.toString());
Review comment:
1. Generally the pipeline shouldn't call this every time.
2. If this condition is met, that means the cluster is not in the right
state anyways, so it's good that we make this a warn log to be able to diagnose
the problem appropriately. Clusters that aren't ill-formed won't get this log.
In other words, you better get the cluster fixed before worrying if there are
too many logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
