dasahcc commented on a change in pull request #968:
URL: https://github.com/apache/helix/pull/968#discussion_r414188369
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
##########
@@ -112,13 +112,13 @@ public static boolean isClusterSetup(String clusterName,
RealmAwareZkClient zkCl
for (int i = 0; i < ret.length; i++) {
if (!ret[i]) {
isValid = false;
- errorMsg.append("Invalid cluster setup, missing znode path:
").append(requiredPaths.get(i))
- .append("\n");
+ errorMsg.append("Invalid cluster setup for cluster:
").append(clusterName)
+ .append(", missing znode path:
").append(requiredPaths.get(i)).append("\n");
}
}
if (!isValid) {
- logger.debug(errorMsg.toString());
+ logger.warn(errorMsg.toString());
Review comment:
@narendly One thing I need to correct. It does not have to be cluster in
ill-form. If there is some network or ZK server issue, partial of the path has
been read. You will get this error frequently. But it does not means the
cluster is not well setup.
For your change, I am fine. But I think we should think about to reduce the
places of using isClusterSetup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
