narendly commented on a change in pull request #968:
URL: https://github.com/apache/helix/pull/968#discussion_r414901472
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
##########
@@ -112,13 +112,13 @@ public static boolean isClusterSetup(String clusterName,
RealmAwareZkClient zkCl
for (int i = 0; i < ret.length; i++) {
if (!ret[i]) {
isValid = false;
- errorMsg.append("Invalid cluster setup, missing znode path:
").append(requiredPaths.get(i))
- .append("\n");
+ errorMsg.append("Invalid cluster setup for cluster:
").append(clusterName)
+ .append(", missing znode path:
").append(requiredPaths.get(i)).append("\n");
}
}
if (!isValid) {
- logger.debug(errorMsg.toString());
+ logger.warn(errorMsg.toString());
Review comment:
What you're talking about is whether it's appropriate to call
isClusterSetup. That's not the focus of this PR - please create a separate
issue to track that work if you think is necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
